chore: upgrade playwright to 1.48.2 #8355

vursen · 2024-12-17T07:26:07Z

Upgrades Playwright to version 1.48.2.

Depends on

test: replace onceResized with nextResize #8387

sissbruecker · 2024-12-17T07:53:36Z

We are still waiting for this to be fixed: microsoft/playwright#32269

vursen · 2024-12-24T10:17:15Z

packages/icon/test/icon-font-polymer.test.js:

 ❌ vaadin-icon - icon fonts > sizing > should subtract vertical padding from height
      AssertionError: expected 24 to be close to 14 +/- 1
        at AssertionError (node_modules/assertion-error/index.js:15:14)
        at node_modules/chai/lib/chai/assertion.js:143:29
        at closeTo (node_modules/chai/lib/chai/core/assertions.js:3027:14)
        at methodWrapper (node_modules/chai/lib/chai/utils/addMethod.js:56:30)
        at packages/icon/test/icon-font.common.js:52:79

This failure is caused by #8397

vursen · 2025-01-08T12:00:41Z

packages/rich-text-editor/test/a11y.common.js

@@ -178,15 +178,15 @@ describe('accessibility', () => {
    it('should move focus to next element after esc followed by tab are pressed', async () => {
      const wrapper = fixtureSync(`<div>
        <vaadin-rich-text-editor></vaadin-rich-text-editor>
-        <button>button</button>
+        <input id="last-global-focusable" />


note: I replaced <button> with <input> in all these tests around to make them pass locally in Webkit. For some reason, buttons are not always reachable by Tab in Webkit on Mac OS.

vursen · 2025-01-08T12:17:37Z

packages/grid/test/keyboard-interaction-mode.common.js

@@ -540,8 +540,7 @@ describe('keyboard interaction mode', () => {
    // Tab downwards
    for (let i = 1; i <= tabToIndex; i++) {
      await rendered();
-      queueMicrotask(async () => await sendKeys({ press: 'Tab' }));
-      await oneEvent(grid, 'focusin');
+      await sendKeys({ press: 'Tab' });


note: Fixes the random failures locally and on CI.

vursen · 2025-01-08T13:21:11Z

packages/select/src/vaadin-select-base-mixin.js

@@ -64,6 +64,7 @@ export const SelectBaseMixin = (superClass) =>
          value: false,
          notify: true,
          reflectToAttribute: true,
+          sync: true,


note: Without sync: true, the overlay was closing asynchronously, which affected subsequent tests and specifically caused the failure of this test in Firefox:

web-components/packages/select/test/validation.common.js

Lines 63 to 71 in b9e3d2f

it('should validate once on close with Tab', async () => {

select.focus();

select.click();

await nextRender();

await sendKeys({ press: 'Tab' });

await nextUpdate(select);

expect(validateSpy.calledOnce).to.be.true;

});

vursen · 2025-01-08T13:24:58Z

packages/dashboard/test/dashboard-keyboard.test.ts

@@ -111,9 +109,9 @@ describe('dashboard - keyboard interaction', () => {
    expect(spy.firstCall.args[0].detail).to.eql({ item: { id: 0 }, value: true });
  });

-  (isChrome || isFirefox ? it : it.skip)('should not remove the widget on backspace', async () => {
+  (isChrome || isFirefox ? it : it.skip)('should not remove the widget on Delete', async () => {


note: Changed to Delete because Backspace sometimes triggered navigation to the previous page in Webkit, which interrupted the execution of the entire test file.

sonarqubecloud · 2025-01-08T13:38:48Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Co-authored-by: Tomi Virkki <[email protected]>

vaadin-bot · 2025-01-09T08:49:08Z

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 20ec46b
error: could not apply 20ec46b... chore: upgrade playwright to 1.48.2 (#8355)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Tomi Virkki <[email protected]>

Co-authored-by: Tomi Virkki <[email protected]>

vaadin-bot · 2025-01-09T14:16:17Z

This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version.

vursen force-pushed the upgrade-playwright-version branch from 0075e0c to 12384a9 Compare December 18, 2024 09:52

vursen mentioned this pull request Dec 23, 2024

test: replace onceResized with nextResize #8387

Merged

1 task

vursen force-pushed the upgrade-playwright-version branch from 925869b to b988e9d Compare December 23, 2024 10:40

vursen mentioned this pull request Dec 23, 2024

[icon] Icon font size ignores dynamically added CSS padding in Safari and Firefox #8397

Open

vursen force-pushed the upgrade-playwright-version branch from 89241b7 to 4577f45 Compare December 24, 2024 07:27

vursen added 4 commits January 7, 2025 15:42

chore: upgrade playwright to 1.48.2

66ee1e2

update CI config to install new playwright

ada7c13

fix focusout issue

8c03947

fix tab tests

8a66554

vursen force-pushed the upgrade-playwright-version branch from 4577f45 to 8a66554 Compare January 7, 2025 13:12

vursen and others added 5 commits January 7, 2025 17:41

add workaround to trigger cqh recalculation

2a41b7d

fix a field-highlighter test by focusing the input before scrolling

62bc73e

fix timing issue in rte test

a284b46

add button to be previous focusable

a0adcc0

add global focusable explicitly

a0ef673

vursen force-pushed the upgrade-playwright-version branch from 28008ca to a0ef673 Compare January 8, 2025 10:15

enable test again

185c1af

vursen force-pushed the upgrade-playwright-version branch 2 times, most recently from ec78310 to f915d38 Compare January 8, 2025 10:41

fix dashboard, radio-group and checkbox tests

1d490b9

vursen force-pushed the upgrade-playwright-version branch from f915d38 to 1d490b9 Compare January 8, 2025 10:42

vursen added 3 commits January 8, 2025 14:49

add missing nextFrame

e251198

use input instead of button to fix local failures

d04d73b

fix more local failures

6ff2b6a

vursen force-pushed the upgrade-playwright-version branch 2 times, most recently from 0b2f280 to 6ff2b6a Compare January 8, 2025 11:23

try to fix tab navigation tests for grid and virtualizer

5e7c09d

vursen commented Jan 8, 2025

View reviewed changes

vursen requested review from tomivirkki, web-padawan and sissbruecker January 8, 2025 12:13

vursen commented Jan 8, 2025

View reviewed changes

tomivirkki approved these changes Jan 8, 2025

View reviewed changes

prevent webkit from going back to about:blank

b9e3d2f

vursen commented Jan 8, 2025

View reviewed changes

web-padawan approved these changes Jan 8, 2025

View reviewed changes

fix another rte timing issue

7827a90

sissbruecker approved these changes Jan 8, 2025

View reviewed changes

vursen merged commit 20ec46b into main Jan 8, 2025
9 checks passed

vursen deleted the upgrade-playwright-version branch January 8, 2025 14:09

vursen mentioned this pull request Jan 8, 2025

test: replace flushGrid with nextFrame to fix local failure #8457

Merged

1 task

vursen added target/24.5 target/24.6 labels Jan 8, 2025

vursen mentioned this pull request Jan 9, 2025

test: fix local test failures in Firefox #8461

Merged

1 task

vaadin-bot pushed a commit that referenced this pull request Jan 9, 2025

chore: upgrade playwright to 1.48.2 (#8355)

8eeeef2

Co-authored-by: Tomi Virkki <[email protected]>

vaadin-bot added cherry-picked-24.6 need to pick manually 24.5 labels Jan 9, 2025

vursen mentioned this pull request Jan 9, 2025

test: fix flaky RTE test by moving Tab tests to a separate suite #8465

Merged

1 task

web-padawan pushed a commit that referenced this pull request Jan 9, 2025

chore: upgrade playwright to 1.48.2 (#8355) (#8462)

3810c72

Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Tomi Virkki <[email protected]>

vursen added a commit that referenced this pull request Jan 9, 2025

chore: upgrade playwright to 1.48.2 (#8355)

93be1f9

Co-authored-by: Tomi Virkki <[email protected]>

vursen mentioned this pull request Jan 9, 2025

chore: upgrade playwright to 1.48.2 (#8355) (CP: 24.5) #8466

Merged

1 task

web-padawan pushed a commit that referenced this pull request Jan 9, 2025

chore: upgrade playwright to 1.48.2 (#8355) (#8466)

5f651a4

Co-authored-by: Tomi Virkki <[email protected]>

vaadin-bot added prerelease version for Vaadin 24.7.0 Released with Vaadin 24.7.0.alpha3 labels Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade playwright to 1.48.2 #8355

chore: upgrade playwright to 1.48.2 #8355

vursen commented Dec 17, 2024 •

edited

Loading

sissbruecker commented Dec 17, 2024

vursen commented Dec 24, 2024

vursen Jan 8, 2025 •

edited

Loading

vursen Jan 8, 2025

vursen Jan 8, 2025 •

edited

Loading

vursen Jan 8, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 8, 2025

vaadin-bot commented Jan 9, 2025

vaadin-bot commented Jan 9, 2025

	it('should validate once on close with Tab', async () => {
	select.focus();
	select.click();
	await nextRender();

	await sendKeys({ press: 'Tab' });
	await nextUpdate(select);
	expect(validateSpy.calledOnce).to.be.true;
	});

chore: upgrade playwright to 1.48.2 #8355

chore: upgrade playwright to 1.48.2 #8355

Conversation

vursen commented Dec 17, 2024 • edited Loading

sissbruecker commented Dec 17, 2024

vursen commented Dec 24, 2024

vursen Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

vursen Jan 8, 2025

Choose a reason for hiding this comment

vursen Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

vursen Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 8, 2025

Quality Gate passed

vaadin-bot commented Jan 9, 2025

vaadin-bot commented Jan 9, 2025

vursen commented Dec 17, 2024 •

edited

Loading

vursen Jan 8, 2025 •

edited

Loading

vursen Jan 8, 2025 •

edited

Loading

vursen Jan 8, 2025 •

edited

Loading